Skip to content

Commit

Permalink
Enable Layout/SpaceAroundOperators cop
Browse files Browse the repository at this point in the history
Follow rails/rails#40436.

This PR enables `Layout/SpaceAroundOperators` cop.
rails/rails#40436 setting requires
RuboCop 1.0 and RuboCop AST 1.0.1 or higher.
rubocop/rubocop#8919

Therefore this PR will be dropping versions that is lack for that requires.
  • Loading branch information
koic committed Oct 25, 2020
1 parent cb5e469 commit 04d40b7
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 77 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/test.yml
Expand Up @@ -6,11 +6,6 @@ jobs:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7]
gemfile:
- gemfiles/rubocop_0.89.gemfile
- gemfiles/rubocop_0.90.gemfile
- gemfiles/rubocop_0.91.gemfile
- gemfiles/rubocop_0.92.gemfile
- gemfiles/rubocop_0.93.gemfile
- gemfiles/rubocop_1.0.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
Expand Down
2 changes: 1 addition & 1 deletion Appraisals
@@ -1,6 +1,6 @@
# frozen_string_literal: true

SUPPORTED_VERSIONS = %w[0.89 0.90 0.91 0.92 0.93 1.0].freeze
SUPPORTED_VERSIONS = %w[1.0].freeze

SUPPORTED_VERSIONS.each do |version|
appraise "rubocop-#{version}" do
Expand Down
3 changes: 3 additions & 0 deletions config/rails.yml
Expand Up @@ -124,6 +124,9 @@ Layout/SpaceAroundEqualsInParameterDefault:
Layout/SpaceAroundKeyword:
Enabled: true

Layout/SpaceAroundOperators:
Enabled: true

Layout/SpaceBeforeComma:
Enabled: true

Expand Down
14 changes: 0 additions & 14 deletions gemfiles/rubocop_0.89.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_0.90.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_0.91.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_0.92.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_0.93.gemfile

This file was deleted.

3 changes: 2 additions & 1 deletion rubocop-rails_config.gemspec
Expand Up @@ -12,7 +12,8 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.required_ruby_version = ">= 2.4.0"

spec.add_dependency "rubocop", ">= 0.89"
spec.add_dependency "rubocop", ">= 1.0"
spec.add_dependency "rubocop-ast", ">= 1.0.1"
spec.add_dependency "rubocop-performance", "~> 1.3"
spec.add_dependency "rubocop-rails", "~> 2.0"
spec.add_dependency "rubocop-packaging", "~> 0.4"
Expand Down

0 comments on commit 04d40b7

Please sign in to comment.