[Fix rubocop#757] Fix a false positive for Rails/ReflectionClassName

Fixes rubocop#757. This PR fixes a false positive for `Rails/ReflectionClassName` when using Ruby 3.1's hash shorthand syntax.
koic · Aug 26, 2022 · 6175e0c · 6175e0c
1 parent 6fc6d22
commit 6175e0c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/changelog/fix_a_false_positive_for_rails_reflection_class_name.md b/changelog/fix_a_false_positive_for_rails_reflection_class_name.md
@@ -0,0 +1 @@
+* [#757](https://github.com/rubocop/rubocop-rails/issues/757): Fix a false positive for `Rails/ReflectionClassName` when using Ruby 3.1's hash shorthand syntax. ([@koic][])
diff --git a/lib/rubocop/cop/rails/reflection_class_name.rb b/lib/rubocop/cop/rails/reflection_class_name.rb
@@ -34,6 +34,8 @@ class ReflectionClassName < Base
 
         def on_send(node)
           association_with_reflection(node) do |reflection_class_name|
+            next if reflection_class_name.value_omission?
+
             add_offense(reflection_class_name.loc.expression)
           end
         end

diff --git a/spec/rubocop/cop/rails/reflection_class_name_spec.rb b/spec/rubocop/cop/rails/reflection_class_name_spec.rb
@@ -80,4 +80,14 @@
       belongs_to :account, class_name: :Account
     RUBY
   end
+
+  context 'Ruby >= 3.1', :ruby31 do
+    it 'does not register an offense when using shorthand syntax' do
+      expect_no_offenses(<<~RUBY)
+        class_name = 'Account'
+
+        has_many :accounts, class_name:
+      RUBY
+    end
+  end
 end