Tweak offense message for Rails/RelativeDateConstant

koic · Mar 27, 2021 · 442f612 · 442f612
1 parent 9469931
commit 442f612
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/lib/rubocop/cop/rails/relative_date_constant.rb b/lib/rubocop/cop/rails/relative_date_constant.rb
@@ -31,7 +31,7 @@ class RelativeDateConstant < Base
         include RangeHelp
         extend AutoCorrector
 
-        MSG = 'Do not assign %<method_name>s to constants as it ' \
+        MSG = 'Do not assign `%<method_name>s` to constants as it ' \
               'will be evaluated only once.'
         RELATIVE_DATE_METHODS = %i[since from_now after ago until before yesterday tomorrow].freeze
 

diff --git a/spec/rubocop/cop/rails/relative_date_constant_spec.rb b/spec/rubocop/cop/rails/relative_date_constant_spec.rb
@@ -30,7 +30,7 @@ class SomeClass
       expect_offense(<<~RUBY)
         class SomeClass
           EXPIRED_AT = 1.week.since
-          ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign since to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `since` to constants as it will be evaluated only once.
         end
       RUBY
 
@@ -47,7 +47,7 @@ def self.expired_at
       expect_offense(<<~RUBY)
         class SomeClass
           RECENT_DATE = Date.yesterday
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign yesterday to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `yesterday` to constants as it will be evaluated only once.
         end
       RUBY
 
@@ -64,7 +64,7 @@ def self.recent_date
       expect_offense(<<~RUBY)
         class SomeClass
           FUTURE_DATE = Time.zone.tomorrow
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign tomorrow to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `tomorrow` to constants as it will be evaluated only once.
         end
       RUBY
 
@@ -81,7 +81,7 @@ def self.future_date
       expect_offense(<<~RUBY)
         class SomeClass
           START_DATE = 2.weeks.ago.to_date
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign ago to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `ago` to constants as it will be evaluated only once.
         end
       RUBY
 
@@ -98,7 +98,7 @@ def self.start_date
       expect_offense(<<~RUBY)
         class SomeClass
           TRIAL_PERIOD = DateTime.current..1.day.since
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign since to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `since` to constants as it will be evaluated only once.
         end
       RUBY
 
@@ -115,7 +115,7 @@ def self.trial_period
       expect_offense(<<~RUBY)
         class SomeClass
           TRIAL_PERIOD = DateTime.current...1.day.since
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign since to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `since` to constants as it will be evaluated only once.
         end
       RUBY
     end
@@ -124,7 +124,7 @@ class SomeClass
       expect_offense(<<~RUBY)
         class SomeClass
           TRIAL_PERIOD = 1.day.ago..DateTime.current
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign ago to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `ago` to constants as it will be evaluated only once.
         end
       RUBY
     end
@@ -133,7 +133,7 @@ class SomeClass
       expect_offense(<<~RUBY)
         class SomeClass
           TRIAL_PERIOD = 1.day.ago...DateTime.current
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign ago to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `ago` to constants as it will be evaluated only once.
         end
       RUBY
     end
@@ -144,7 +144,7 @@ class SomeClass
       expect_offense(<<~RUBY)
         class SomeClass
           EXPIRED_AT ||= 1.week.since
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign since to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `since` to constants as it will be evaluated only once.
         end
       RUBY
     end
@@ -155,8 +155,8 @@ class SomeClass
       expect_offense(<<~RUBY)
         class SomeClass
           START, A, x = 2.weeks.ago, 1.week.since, 5
-          ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign ago to constants as it will be evaluated only once.
-                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign since to constants as it will be evaluated only once.
+          ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `ago` to constants as it will be evaluated only once.
+                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not assign `since` to constants as it will be evaluated only once.
         end
       RUBY
     end