Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable nitro on production build #4713

Merged
merged 14 commits into from
Jan 16, 2023
Merged

chore: enable nitro on production build #4713

merged 14 commits into from
Jan 16, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 15, 2023

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-01-16 at 00 23 17

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 190664c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c537ab5531c600082e4276
😎 Deploy Preview https://deploy-preview-4713--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian changed the title Chore/bump-nuxt-bridge chore: enable nitro on production build Jan 15, 2023
@yangwao
Copy link
Member

yangwao commented Jan 15, 2023

it's happening 🤔👀

@preschian
Copy link
Member Author

it's happening 🤔👀

hopefully 🙈

@preschian preschian marked this pull request as ready for review January 15, 2023 17:31
@preschian preschian requested a review from a team as a code owner January 15, 2023 17:31
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team January 15, 2023 17:31
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

I've tested new QR code implementation

Note:
small build error:

[Error: ENOENT: no such file or directory, chmod '.../nft-gallery/.nuxt/pwa/icons/144x144.bdfd6a1d.png'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'chmod',
  path: '.../nft-gallery/.nuxt/pwa/icons/144x144.bdfd6a1d.png'
}

 ERROR  [unhandledRejection] 1

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 16, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

Good job! Now I could not see the warning about the package version while building and also runtime.

@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

why it was canceled 👀
image

@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

6:27:52 PM: Finished processing build request in 4m38.308200318s

idk why I thought this will speed up build times 🤔

@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

currently there is no official pwa modules for nuxt3/bridge, for temporary using this kevinmarrec/nuxt-pwa-module

let's check on this later one

@preschian
Copy link
Member Author

why it was canceled 👀 image

seems stuck
image

let me sync with main again

@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

@preschian ups, conflict 🙈

@codeclimate
Copy link

codeclimate bot commented Jan 16, 2023

Code Climate has analyzed commit 190664c and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

pay 80 usd

@yangwao yangwao merged commit 8615680 into main Jan 16, 2023
@yangwao yangwao deleted the chore/bump-nuxt-bridge branch January 16, 2023 12:04
@yangwao
Copy link
Member

yangwao commented Jan 16, 2023

😍 Perfect, I’ve sent the payout
💵 $80 @ 31.54 USD/KSM ~ 2.536 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x531348abb5a06a99b9e338c47eeaa735483b7bf1ba5fb489bd9c7c23edbd51f9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check @nuxt/kit lock later Bump new @polkadot packages some @polkadot packages has multiple versions
4 participants