Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove awaits #10302

Merged
merged 3 commits into from
May 15, 2024
Merged

remove awaits #10302

merged 3 commits into from
May 15, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 15, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

@daiagi daiagi requested a review from a team as a code owner May 15, 2024 08:35
@daiagi daiagi requested review from vikiival and hassnian and removed request for a team May 15, 2024 08:35
Copy link

netlify bot commented May 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 175b386
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6644760d1a09c60008a384c2
😎 Deploy Preview https://deploy-preview-10302--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-pages bot commented May 15, 2024

Deploying kodaart-production with  Cloudflare Pages  Cloudflare Pages

Latest commit: 175b386
Status: ✅  Deploy successful!
Preview URL: https://71cd892e.kodaart-production.pages.dev
Branch Preview URL: https://performance-remove-awaits-in.kodaart-production.pages.dev

View logs

Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit 175b386 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@daiagi daiagi requested review from preschian and removed request for hassnian May 15, 2024 08:50
@vikiival
Copy link
Member

Just Q
Won't this have a negative effect on the data ? since without await you are returning Promise<T> instead of T

https://nuxt.com/docs/api/composables/use-async-data

@vikiival
Copy link
Member

If everything works we can merge

@daiagi
Copy link
Contributor Author

daiagi commented May 15, 2024

@vikiival
incorrect docs?

image

useAsyncData returns AsyncData

image

but the docs claim it returns Promise<AsyncData>>

https://nuxt.com/docs/api/composables/use-async-data#type

anyway.. it works

@vikiival vikiival added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit d13865a May 15, 2024
20 checks passed
@vikiival vikiival deleted the performance/remove-awaits-in-profile branch May 15, 2024 12:23
@vikiival vikiival mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blocking requests for the profile endpoints
4 participants