-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Save Art: make it more user-friendly #10298
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello,Daiagi, Could you explain about it more detail? |
The issue is about having a quick easy way to download full quality image, without opening the image in full screen. I have tested your pr and found that the image quality downloaded is the same as it was before. |
Code Climate has analyzed commit 75cc6c2 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
To improve image quality while downloading, especially when using JavaScript, you can consider the following approach: Compression Optimization: Compresses images in a way that maintains high quality. This may include using modern image formats such as WebP or efficient compression algorithms to reduce file size without sacrificing visual fidelity. Dynamic Image Rendering: Dynamically render images at higher quality before downloading. Before starting the download process, leverage HTMLCanvasElement and Context2D API to manipulate and enhance image quality as needed. |
Now the quality is way worse and a better UI solution was not provided. |
Needs Design check
Needs QA check
Context
Before submitting pull request, please make sure:
Optional
I've tested it at </ahp/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases
Are you at Koda Ecosystem Telegram?
Screenshot 📸
** on UI; a screenshot is best to understand changes for others.