Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Save Art: make it more user-friendly #10298

Closed
wants to merge 6 commits into from

Conversation

panda6151025
Copy link

@panda6151025 panda6151025 commented May 14, 2024

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

Screenshot 📸

  • [] My fix has changed **
    Capture1
    ** on UI; a screenshot is best to understand changes for others.

@panda6151025 panda6151025 requested a review from a team as a code owner May 14, 2024 15:31
@panda6151025 panda6151025 requested review from daiagi and hassnian and removed request for a team May 14, 2024 15:31
Copy link

netlify bot commented May 14, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 75cc6c2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6646942c65c5f9000843420a
😎 Deploy Preview https://deploy-preview-10298--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title Fix the issue10199 fix: Save Art: make it more user-friendly May 15, 2024
@daiagi
Copy link
Contributor

daiagi commented May 15, 2024

image from canary:
hdd_

image from this pr:
hdd_ hdd #115

Both 119kb, 300pxX300px, same quality

@daiagi daiagi added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 15, 2024
@panda6151025
Copy link
Author

Hello,Daiagi, Could you explain about it more detail?

@daiagi
Copy link
Contributor

daiagi commented May 15, 2024

The issue is about having a quick easy way to download full quality image, without opening the image in full screen.

I have tested your pr and found that the image quality downloaded is the same as it was before.
Therfore, this pr does not solve the issue

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit 75cc6c2 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@panda6151025
Copy link
Author

To improve image quality while downloading, especially when using JavaScript, you can consider the following approach:
Use high-resolution images: Make sure you are using a high-resolution image as the source for your download. High-quality images naturally provide better clarity and detail.

Compression Optimization: Compresses images in a way that maintains high quality. This may include using modern image formats such as WebP or efficient compression algorithms to reduce file size without sacrificing visual fidelity.

Dynamic Image Rendering: Dynamically render images at higher quality before downloading. Before starting the download process, leverage HTMLCanvasElement and Context2D API to manipulate and enhance image quality as needed.
So I drew an image on a canvas. We then use the nuxt/image module to compress the image into Webp.
As a result, image size was reduced from 121 kbytes to 30 kbytes and image quality was improved.

@prury
Copy link
Member

prury commented May 17, 2024

Now the quality is way worse and a better UI solution was not provided.
Also, we do not welcome chatgptesque comments, closing PR.

@prury prury closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Art: make it more user-friendly
3 participants