Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Top Collection buttons #10286

Closed
wants to merge 11 commits into from
Closed

fix Top Collection buttons #10286

wants to merge 11 commits into from

Conversation

FG-HJ
Copy link

@FG-HJ FG-HJ commented May 13, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Uploading Screenshot_7.png…
    Uploading Screenshot_8.png…

@FG-HJ FG-HJ requested a review from a team as a code owner May 13, 2024 13:44
@FG-HJ FG-HJ requested review from daiagi and hassnian and removed request for a team May 13, 2024 13:44
Copy link

netlify bot commented May 13, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a4698d6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6646256b579ee20008518b58
😎 Deploy Preview https://deploy-preview-10286--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented May 13, 2024

i think changing the neobutton css directly affected too many items across app, can you come up with a different solution?

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 13, 2024
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change affects the entire app

as I said here #10267 (comment)

you need to override NeoButton's styles where that component is used, in this case TopCollections.vue

@FG-HJ FG-HJ requested a review from hassnian May 14, 2024 04:21
@hassnian
Copy link
Contributor

@FG-HJ you requested a new review but I don't see any new changes , forgot to push ?

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NeoButton.scss shouldn't be changed at all

just override the min-w ofNeoButton.scss inside TopCollections.vue

@FG-HJ FG-HJ requested a review from hassnian May 15, 2024 23:19
@prury
Copy link
Member

prury commented May 16, 2024

@FG-HJ there should not be changes in the pnpm-lock.yaml file in your PR

Copy link

socket-security bot commented May 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@kodadot1/hyperdata@0.0.1-rc.4 None 0 22.4 kB vikiival
npm/@kodadot1/minimark@0.1.14-rc.0 None +1 201 kB vikiival
npm/@kodadot1/minipfs@0.4.3-rc.1 None 0 22.6 kB vikiival
npm/@kodadot1/sub-api@0.3.1-rc.0 None +3 700 kB vikiival
npm/@nuxt/content@2.12.1 filesystem Transitive: environment, eval, network +28 9.3 MB farnabaz
npm/@nuxt/image@1.7.0 environment +4 1.11 MB danielroe
npm/@nuxt/types@2.17.3 Transitive: environment +38 6.78 MB danielroe
npm/@nuxtjs/apollo@5.0.0-alpha.6 environment, filesystem Transitive: network +11 8.07 MB diizzayy
npm/@nuxtjs/color-mode@3.4.1 Transitive: environment +4 1 MB danielroe
npm/@nuxtjs/device@3.1.1 Transitive: environment +4 997 kB devneko
npm/@nuxtjs/google-fonts@3.2.0 Transitive: environment +4 985 kB ricardogobbosouza
npm/@nuxtjs/i18n@8.3.1 eval Transitive: environment, filesystem, unsafe +25 11.9 MB rchl
npm/@nuxtjs/sitemap@5.1.5 Transitive: environment, eval, filesystem, network +57 40 MB harlan_zw
npm/@oruga-ui/oruga-next@0.7.0 None 0 4.17 MB astagi
npm/@paraspell/sdk@5.2.1 None +1 494 kB dudo50
npm/@pinia/nuxt@0.5.1 Transitive: environment +4 981 kB posva
npm/@playwright/test@1.44.0 None 0 25.4 kB yurys
npm/@polkadot/api-base@10.13.1 Transitive: network +10 30.5 MB polkadotjs
npm/@polkadot/api@10.13.1 Transitive: network +17 36.6 MB polkadotjs
npm/@polkadot/apps-config@0.135.1 Transitive: environment, network +126 165 MB polkadotjs
npm/@polkadot/extension-dapp@0.47.3 None 0 49.1 kB polkadotjs
npm/@polkadot/extension-inject@0.47.3 Transitive: network +11 34.4 MB polkadotjs
npm/@polkadot/types@10.13.1 None +6 4.93 MB polkadotjs
npm/@polkadot/ui-keyring@3.6.6 None +1 319 kB polkadotjs
npm/@polkadot/ui-settings@3.6.6 environment +2 207 kB polkadotjs
npm/@polkadot/util-crypto@12.6.2 None +14 5.84 MB polkadotjs
npm/@polkadot/util@12.6.2 None +6 731 kB polkadotjs
npm/@polkadot/vue-identicon@3.6.6 None +1 115 kB polkadotjs
npm/@ramp-network/ramp-instant-sdk@4.0.5 None +1 390 kB jakubsta
npm/@transak/transak-sdk@1.4.1 None 0 67.7 kB kutsav
npm/@types/jest@27.5.2 None 0 71.4 kB types
npm/@types/lodash@4.17.1 None 0 862 kB types
npm/@types/markdown-it@13.0.8 None +2 48.2 kB types
npm/@types/node@20.12.11 None 0 2.06 MB types
npm/@types/prismjs@1.26.4 None 0 19.2 kB types
npm/@typescript-eslint/eslint-plugin@6.21.0 None +10 5.24 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 None +4 1.37 MB jameshenry
npm/@vite-pwa/nuxt@0.7.0 Transitive: environment +4 1.03 MB userquin
npm/@vitejs/plugin-vue@4.6.2 environment 0 185 kB vitebot
npm/@vitejs/plugin-vue@5.0.4 environment 0 185 kB vitebot
npm/@vitest/coverage-c8@0.33.0 Transitive: filesystem, unsafe +9 795 kB oreanno
npm/@vitest/coverage-istanbul@0.34.6 None 0 16.3 kB oreanno
npm/@vueuse/core@9.13.0 network +3 1.36 MB antfu
npm/@vueuse/nuxt@9.13.0 Transitive: environment +5 1.2 MB antfu
npm/autoprefixer@10.4.19 environment Transitive: filesystem +2 2.27 MB ai
npm/bulma@0.9.4 None 0 1.26 MB jgthms
npm/changelogen@0.5.5 environment, network +1 133 kB pi0
npm/chart.js@4.4.2 None +1 5.01 MB chartjs-ci
npm/chartjs-adapter-date-fns@3.0.0 None 0 288 kB chartjs-ci
npm/chartjs-plugin-zoom@2.0.1 None 0 87.7 kB chartjs-ci

🚮 Removed packages: npm/cross-env@7.0.3, npm/graphql@16.8.1, npm/lodash@4.17.21, npm/typescript@5.4.5

View full report↗︎

Copy link

socket-security bot commented May 16, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/@nuxt/telemetry@2.5.3
  • Note: Can be disabled by setting the environment variable NUXT_TELEMETRY_DISABLED=1
  • orphan: npm/@nuxt/telemetry@2.5.3

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@nuxt/telemetry@2.5.3

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit a4698d6 and detected 0 issues on this pull request.

View more on Code Climate.

@FG-HJ FG-HJ requested review from hassnian May 16, 2024 15:30
@FG-HJ FG-HJ closed this May 16, 2024
@FG-HJ FG-HJ reopened this May 16, 2024
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@FG-HJ FG-HJ closed this May 16, 2024
@FG-HJ FG-HJ deleted the koda-fix branch May 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-✋ S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Collection buttons got reduced
3 participants