Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Modify constructor's options type in the Application class #1812

Merged
merged 1 commit into from
Apr 22, 2024
Merged

docs: Modify constructor's options type in the Application class #1812

merged 1 commit into from
Apr 22, 2024

Conversation

leslieXin92
Copy link
Contributor

@leslieXin92 leslieXin92 commented Apr 22, 2024 •
edited

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@leslieXin92 leslieXin92 changed the title docs: Modify options type in the Application class docs: Modify constructor's options type in the Application class Apr 22, 2024
@leslieXin92 leslieXin92 changed the title docs: Modify constructor's options type in the Application class feat: Modify constructor's options type in the Application class Apr 22, 2024
fengmk2
fengmk2 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 changed the title feat: Modify constructor's options type in the Application class docs: Modify constructor's options type in the Application class Apr 22, 2024
@fengmk2 fengmk2 merged commit f85214a into koajs:master Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leslieXin92 @fengmk2