feat: change set status assert, allowing valid custom statuses (#1308)

koajs · Jan 28, 2019 · b7bfa71 · b7bfa71
1 parent 72f325b
commit b7bfa71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/response.js b/lib/response.js
@@ -83,8 +83,8 @@ module.exports = {
   set status(code) {
     if (this.headerSent) return;
 
-    assert('number' == typeof code, 'status code must be a number');
-    assert(statuses[code], `invalid status code: ${code}`);
+    assert(Number.isInteger(code), 'status code must be a number');
+    assert(code >= 100 && code <= 999, `invalid status code: ${code}`);
     this._explicitStatus = true;
     this.res.statusCode = code;
     if (this.req.httpVersionMajor < 2) this.res.statusMessage = statuses[code];

diff --git a/test/response/status.js b/test/response/status.js
@@ -24,8 +24,8 @@ describe('res.status=', () => {
     describe('and invalid', () => {
       it('should throw', () => {
         assert.throws(() => {
-          response().status = 999;
-        }, /invalid status code: 999/);
+          response().status = 99;
+        }, /invalid status code: 99/);
       });
     });