Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ggcr and handle breaking change #866

Merged
merged 1 commit into from Nov 9, 2022
Merged

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Oct 24, 2022

Supercedes #865

google/go-containerregistry#1413 changed the API signature of NewCmdAuthGet to allow it to consider any compiled-in cred helpers.

@codecov-commenter
Copy link

Codecov Report

Merging #866 (016a1de) into main (811b34a) will increase coverage by 0.03%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   51.29%   51.33%   +0.03%     
==========================================
  Files          44       44              
  Lines        3394     3407      +13     
==========================================
+ Hits         1741     1749       +8     
- Misses       1426     1430       +4     
- Partials      227      228       +1     
Impacted Files Coverage Δ
pkg/commands/resolver.go 36.89% <61.53%> (+1.01%) ⬆️
pkg/commands/root.go 65.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JohnTitor
Copy link

JohnTitor commented Dec 27, 2022

@imjasonh Could you cut a new release including this? It would fix a build issue with a recent build tool. Thanks in advance!

@imjasonh
Copy link
Member Author

@imjasonh Could you cut a new release including this? It would fix a build issue with a recent build tool. Thanks in advance!

If you depend on ko as a library, you should be able to go get -u github.com/google/ko@main, or add a replace to your go.mod to pick up this change. If those don't work for some reason, let me know and I can try to help debug it.

We plan to cut a release in the new year, to account for some importpath changes we have planned.

@JohnTitor
Copy link

JohnTitor commented Dec 30, 2022

Yeah, that indeed fixed our issue, it'd be great if we have a release to specify a tag instead of a commit SHA.

We plan to cut a release in the new year, to account for some importpath changes we have planned.

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants