Allow specifying binary path in image

[justinsb]

Previously this was hard-coded to /ko-app/<app-name>.

go-releaser allows specifying the binary (including directory prefix);
we now support the same.

[justinsb]

Opening for discussion, I expect we'll want e.g. some test coverage and docs.

[codecov-commenter]

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.16% 🎉

Comparison is base (daab1ac) 49.20% compared to head (0da27f1) 49.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   49.20%   49.37%   +0.16%     
==========================================
  Files          44       44              
  Lines        3652     3670      +18     
==========================================
+ Hits         1797     1812      +15     
- Misses       1623     1626       +3     
  Partials      232      232              

Files Changed	Coverage Δ
pkg/build/config.go	0.00% <ø> (ø)
pkg/build/gobuild.go	57.88% <72.22%> (+0.52%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[imjasonh]

This change looks pretty good to me. I think we should also support it as a flag in ko build (flag name ideas welcome!)

[hakman]

@justinsb I see ko has KO_DATA_PATH so maybe split this into KO_APP_PATH and KO_APP_NAME? (just a thought to make things more consistent)

[justinsb]

I see ko has KO_DATA_PATH so maybe split this into KO_APP_PATH and KO_APP_NAME? (just a thought to make things more consistent)

I was trying to follow go-releaser here in terms of how this value was provided by the user. It's not a perfect match because goreleaser also adds goos and goarch, but I think that's primarily to keep things separated in the artifacts directory, and the container image does that naturally.

It sounds like we do want to export the path to the binary for e.g. dlv, which we can add (not sure if a separate PR)

I think we should also support it as a flag in ko build (flag name ideas welcome!)

I added a flag --binary, just as a strawman. Happy to change the name.

I also added some tests (and note: I think the app layer test was actually checking the data layer, so I tweaked that)

[justinsb]

What's the next step here? Any thoughts on the flag @imjasonh ?

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

[justinsb]

Not stale, needs review.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

[abh]

Still needs review ...