Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve platform support #12

Merged
merged 2 commits into from Jun 25, 2022
Merged

Improve platform support #12

merged 2 commits into from Jun 25, 2022

Conversation

davnn
Copy link
Contributor

@davnn davnn commented Jun 9, 2022

Hi!

thanks for the great package. It would be great if we could provide pre-built packages for multiple platforms and Python versions and this pull request does exactly that.

Thanks,
David

@kno10
Copy link
Owner

kno10 commented Jun 15, 2022

Thank you, much appreciated.
However, the action does not appear to work entriely yet:

pypa/gh-action-pypi-publish@master
Error: Container action is only supported on Linux

It seems there is an additional step necessary, where the compiled artifacts are collected and (if all compiles were successful) uploaded: pypa/gh-action-pypi-publish#48 (comment)

@davnn
Copy link
Contributor Author

davnn commented Jun 15, 2022

Sorry, I didn't see that you already worked on it. Are there any problems still?

@kno10
Copy link
Owner

kno10 commented Jun 17, 2022

It seems to work, but I need to check whether it is worth to add cross-compilation for Linux targets on other CPUs, in particular aarch64, arm. Maybe musl, and of course for Apples new M1 CPUs.

@davnn
Copy link
Contributor Author

davnn commented Jun 19, 2022

I believe further support will only be possible hosting your own runners, see [1, 2], or using a different CI service. Not sure if that's worth the effort.

[1] actions/runner#805
[2] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@kno10
Copy link
Owner

kno10 commented Jun 20, 2022

At least for linux, cross-compilation should be possible, e.g.,
https://github.com/messense/crfs-rs/blob/0e77658d65abefef8818cc25b0a57941ff41269b/.github/workflows/Python.yml#L105-L109
and there appears to be a github action docker image for osxcross, too (but it does not mention aarch64-apple-darwin for M1):
https://github.com/marketplace/actions/shogan-rust-static-build
but M1 does not appear to be perfectly supported yet by rust tooling: rust-lang/rust#73908

@kno10 kno10 merged commit 1b24f4d into kno10:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants