fix(VDialog): change the role from "document" to "dialog"

fixes vuetifyjs#14231
knknk98 · Jan 13, 2022 · eb2c60b · eb2c60b
1 parent 9e2edf3
commit eb2c60b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/vuetify/src/components/VDialog/VDialog.ts b/packages/vuetify/src/components/VDialog/VDialog.ts
@@ -253,7 +253,7 @@ export default baseMixins.extend({
           this.$createElement('div', {
             class: this.contentClasses,
             attrs: {
-              role: 'document',
+              role: 'dialog',
               tabindex: this.isActive ? 0 : undefined,
               ...this.getScopeIdAttrs(),
             },

diff --git a/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap b/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`VDialog.ts should only set tabindex if active 1`] = `
-<div role="document"
+<div role="dialog"
      class="v-dialog__content"
      style="z-index: 0;"
 >
@@ -13,7 +13,7 @@ exports[`VDialog.ts should only set tabindex if active 1`] = `
 `;
 
 exports[`VDialog.ts should only set tabindex if active 2`] = `
-<div role="document"
+<div role="dialog"
      class="v-dialog__content v-dialog__content--active"
      style="z-index: 202; z-index: 202;"
      tabindex="0"