Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Definition for orderBy with Raw Expression Issue 5711 #5803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

redaxle
Copy link

@redaxle redaxle commented Feb 20, 2024

This change adds the Raw type when used as a column definition in orderBy in order to satisfy the type checks. Typescript will currently indicate that there's no overload for any of the following:

knex('foo').orderBy(knex.raw('count(*)'), 'desc');
knex('foo').orderBy([{ column: knex.raw('count(*)') }]);

Use of a Raw result for the column will no longer result in a type error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant