Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FOR UPDATE OF with explicit schema #5791

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix FOR UPDATE OF with explicit schema #5791

wants to merge 2 commits into from

Commits on Jan 19, 2024

  1. Fix FOR UPDATE OF with explicit schema (knex#5053) 

    When the _tableNames helper was written there were multiple methods
hitting it, but they've since been merged into the single _lockingClause
method. Given that the only really interesting thing it was doing was
prepending the schema name--which is the incorrect behavior this commit
fixes--it didn't seem worth keeping at this point.

I'm not sure you'd say `.withSchema('public')` in a real query but it
lets me exercise the behavior in question without having to learn enough
about knex's test environment to stand up a discrete schema. I suppose
it's plausible that a reasonable maintainer would go "hm that's silly
and redundant" and inadvertently remove coverage for this bug, though.
    @ErinCall
    ErinCall committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d69d9dc View commit details
    Browse the repository at this point in the history

  2. Remove leftover console.log 

    Turns out your changes only show up in git if you press "save" in your
editor. Who knew!
    @ErinCall
    ErinCall committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9a8e9af View commit details
    Browse the repository at this point in the history