Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle db returning * fixes #5598

Merged
merged 1 commit into from Jul 4, 2023
Merged

Conversation

Fleetrun10
Copy link
Contributor

Should fix #3837 so that using update with returning * actually returns an object instead of the number of rows.
Also fixes the bug introduced within #3668 that causes the returning * to fail when run within a transaction

@Fleetrun10 Fleetrun10 changed the title fix #3837, returning * fix within transaction oracle db returning * fixes Jun 8, 2023
@coveralls
Copy link

coveralls commented Jun 28, 2023

Coverage Status

coverage: 92.788%. remained the same when pulling a63779e on Fleetrun10:master into 89cebb0 on knex:master.

…isntead of the number of rows. Also fixes returning * when within a transaction
@OlivierCavadenti OlivierCavadenti merged commit 2a6c20f into knex:master Jul 4, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update() with returning("*") is returning 1
3 participants