Fix cancelling timeouted queued queries in transactions for MySQL using driver dequeue method #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximelkin
reviewed
Apr 18, 2021
|
Nice |
maximelkin
reviewed
Apr 19, 2021
martinmacko47
force-pushed
the
promise-all-timeout-error+dequeue-in-driver
branch
from
8f3dfab
to
7f7907f
Compare
* Use connection pause/resume to prevent kill race condition * Move connection resume before destroy raw connection
@maximelkin @kibertoad Hi. Do you think, is there anything we can do to have those timeouts in transactions on MySQL fixed? Diver maintainers did not respond to my PR mysqljs/mysql#2480, besides the first mysqljs/mysql#2478 (comment). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4415
Addaptation of PR #4416 using draft implementations of
Query.dequeue()formysqlandmysql2drivers:mysql2team responds to the issue)