Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracledb: commit was a no-op causing race conditions #3668

Merged
merged 3 commits into from Feb 16, 2020
Merged

oracledb: commit was a no-op causing race conditions #3668

merged 3 commits into from Feb 16, 2020

Commits on Jan 6, 2020

  1. fix knex#3612 commit was a no-op causing race conditions 

    The underlying issue was that query *always* committed, even during a transaction. The previous fix was to just disable commitAsync in a transaction but then that also disabled explicit commit calls. Instead, this fix disables query's commits during transactions so that explicit commits still work.
    @jakecoffman
    jakecoffman committed Jan 6, 2020
    Copy the full SHA
    2b290e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Merge branch 'master' into fix-3612

    @jakecoffman
    jakecoffman committed Feb 14, 2020
    Copy the full SHA
    13e4f37 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2020

  1. enable some oracle tests that seem to pass now

    @jakecoffman
    jakecoffman committed Feb 16, 2020
    Copy the full SHA
    ef37103 View commit details
    Browse the repository at this point in the history