Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unresolved promise in cancelQuery(..) ... #3666

Merged
merged 2 commits into from Feb 16, 2020
Merged

Fixed unresolved promise in cancelQuery(..) ... #3666

merged 2 commits into from Feb 16, 2020

Commits on Feb 15, 2020

  1. Fixed unresolved promise in cancelQuery(..) ... 

    ... more specifically: cancelQuery(..) was attempting to
"cancel the cancellation" after 100ms.  However, it was not
actually achieving this objective.  In reality, the cancellation
was still running in the background even though the caller had
already moved on.

Later on, the cancellation would ACTUALLY fail due to a resource
allocation issue (ie: no more connections in the Tarn pool).
This would then result in an unhandled Promise rejection.
    @briandamaged
    briandamaged committed Feb 15, 2020
    Copy the full SHA
    cde8c7d View commit details
    Browse the repository at this point in the history

  2. Made linter happy. (Removed unused variable)

    @briandamaged
    briandamaged committed Feb 15, 2020
    Copy the full SHA
    d17ee7f View commit details
    Browse the repository at this point in the history