-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Support for Liftoff's Preloaders #3613
Commits on Jan 5, 2020
-
CLI uses Liftoff to handle knexfile discovery
Brian Lauber committedJan 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 6fabb35 - Browse repository at this point
Copy the full SHA 6fabb35View commit details -
Dead code removal: config resolver functions...
... Specifically: - resolveDefaultKnexfilePath(...) - resolveKnexFilePath(...)
Brian Lauber committedJan 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 516d2e5 - Browse repository at this point
Copy the full SHA 516d2e5View commit details -
Backwards compatibility w/ the undocumented config.ext property
This property is used when inferring the appropriate extension for the migration files
Brian Lauber committedJan 5, 2020 Configuration menu - View commit details
-
Copy full SHA for e820a2b - Browse repository at this point
Copy the full SHA e820a2bView commit details -
Removed invalid knexfile/knexpath args from Liftoff#launch(..)
Brian Lauber committedJan 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 772c47d - Browse repository at this point
Copy the full SHA 772c47dView commit details
Commits on Jan 6, 2020
-
Added some specs for --cwd and --knexfile interaction
Brian Lauber committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 10bb520 - Browse repository at this point
Copy the full SHA 10bb520View commit details -
Fix: removed the ".only" qualifier from the testcase
Brian Lauber committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 9ea3f5c - Browse repository at this point
Copy the full SHA 9ea3f5cView commit details -
Added some migrations to the knexfile-relative tests...
... this way, we can be sure that the correct migrations are being run. (As opposed to a directory lookup error, or something like that)
Brian Lauber committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 689e3eb - Browse repository at this point
Copy the full SHA 689e3ebView commit details -
Added test case to verify that CWD is changed correctly
Brian Lauber committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 74984a5 - Browse repository at this point
Copy the full SHA 74984a5View commit details
Commits on Jan 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5a79595 - Browse repository at this point
Copy the full SHA 5a79595View commit details -
Work-around for nyc interfering w/ Liftoff's ".ts" handling ...
... Specifically: the default configuration for nyc causes it to add ".ts" to the the `require.extensions` list. The problem: Liftoff consults `require.extensions` when deciding which modules need to be preloaded. Since ".ts" is already on the list, Liftoff decides that "ts-node" must have already been preloaded. Therefore, it hands control off to the Knex CLI without ever registering Typescript support. Consequently, the Knex CLI will explode if it attempts to open a Knexfile that was written in Typescript. In other words: this error only occurs when `nyc` (or another tool) modifies `require.extensions` before handing control over to the Knex CLI.
Configuration menu - View commit details
-
Copy full SHA for 73f5b94 - Browse repository at this point
Copy the full SHA 73f5b94View commit details
Commits on Jan 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2a5aceb - Browse repository at this point
Copy the full SHA 2a5acebView commit details