Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Support for Liftoff's Preloaders #3613

Merged
merged 11 commits into from
Feb 8, 2020

Commits on Jan 5, 2020

  1. CLI uses Liftoff to handle knexfile discovery

    Brian Lauber committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    6fabb35 View commit details
    Browse the repository at this point in the history
  2. Dead code removal: config resolver functions...

    ... Specifically:
     - resolveDefaultKnexfilePath(...)
     - resolveKnexFilePath(...)
    Brian Lauber committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    516d2e5 View commit details
    Browse the repository at this point in the history
  3. Backwards compatibility w/ the undocumented config.ext property

    This property is used when inferring the appropriate extension
    for the migration files
    Brian Lauber committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    e820a2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    772c47d View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Added some specs for --cwd and --knexfile interaction

    Brian Lauber committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    10bb520 View commit details
    Browse the repository at this point in the history
  2. Fix: removed the ".only" qualifier from the testcase

    Brian Lauber committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    9ea3f5c View commit details
    Browse the repository at this point in the history
  3. Added some migrations to the knexfile-relative tests...

    ... this way, we can be sure that the correct migrations are
    being run.  (As opposed to a directory lookup error, or something
    like that)
    Brian Lauber committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    689e3eb View commit details
    Browse the repository at this point in the history
  4. Added test case to verify that CWD is changed correctly

    Brian Lauber committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    74984a5 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Configuration menu
    Copy the full SHA
    5a79595 View commit details
    Browse the repository at this point in the history
  2. Work-around for nyc interfering w/ Liftoff's ".ts" handling ...

    ... Specifically: the default configuration for nyc causes it
    to add ".ts" to the the `require.extensions` list.
    
    The problem: Liftoff consults `require.extensions` when deciding
    which modules need to be preloaded.  Since ".ts" is already on
    the list, Liftoff decides that "ts-node" must have already been
    preloaded.  Therefore, it hands control off to the Knex CLI
    without ever registering Typescript support.  Consequently, the
    Knex CLI will explode if it attempts to open a Knexfile that was
    written in Typescript.
    
    In other words: this error only occurs when `nyc` (or another
    tool) modifies `require.extensions` before handing control over
    to the Knex CLI.
    briandamaged committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    73f5b94 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. Configuration menu
    Copy the full SHA
    2a5aceb View commit details
    Browse the repository at this point in the history