Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Support ESM for knexfile, migrations and seeds #3601

Closed
wants to merge 1 commit into from
Closed

WIP: Support ESM for knexfile, migrations and seeds #3601

wants to merge 1 commit into from

Conversation

lorefnon
Copy link
Collaborator

@lorefnon lorefnon commented Dec 30, 2019 •
edited

  • Ensure that commonjs compatibility is retained
  • Ensure that ESM migrations/seeds/knexfile are correctly imported
  • When type=module is specified in package.json then generated files should be ESM.

@kibertoad
Copy link
Collaborator

@lorefnon Is this still relevant after #3616 is merged?

@lorefnon
Copy link
Collaborator Author

No, this can be closed now.

@lorefnon lorefnon closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorefnon @kibertoad