Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection configuration provider - without changes to drivers #3497

Merged
merged 14 commits into from Oct 27, 2019
Merged

Connection configuration provider - without changes to drivers #3497

merged 14 commits into from Oct 27, 2019

Commits on Oct 25, 2019

  1. added support for connection configuration provider

    @oranoran
    oranoran committed Oct 25, 2019
    Copy the full SHA
    3ca0155 View commit details
    Browse the repository at this point in the history

  2. removed a few redundant lines and improved readibility

    @oranoran
    oranoran committed Oct 25, 2019
    Copy the full SHA
    46fc1c9 View commit details
    Browse the repository at this point in the history

  3. added test for synchronouse provider, and fixed potential unwanted si… 

    …de effect between tests
    @oranoran
    oranoran committed Oct 25, 2019
    Copy the full SHA
    8aa3edc View commit details
    Browse the repository at this point in the history

  4. renamed expired => expirationChecker, removed explicit comparison to … 

    …"undefined" so "null" will also be supported.
    @oranoran
    oranoran committed Oct 25, 2019
    Copy the full SHA
    3bdf0bf View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. Moved connection config provider tests to integration so they cover a… 

    …ll DBs + removing expiryChecker from config being passed to DB drivers
    @oranoran
    oranoran committed Oct 26, 2019
    Copy the full SHA
    6d0b78b View commit details
    Browse the repository at this point in the history

  2. fixed removal of tests from tape

    @oranoran
    oranoran committed Oct 26, 2019
    Copy the full SHA
    9d3c543 View commit details
    Browse the repository at this point in the history

  3. Simplified use of async/await and promises for connection config prov… 

    …ider
    @oranoran
    oranoran committed Oct 26, 2019
    Copy the full SHA
    826fbfd View commit details
    Browse the repository at this point in the history

  4. Setting this.connectionConfigExpirationChecker to null instead of rem… 

    …oving it (and also initializing it to null if needed) - in order to maintain a stable set of properties in the client.
    @oranoran
    oranoran committed Oct 26, 2019
    Copy the full SHA
    01b6d28 View commit details
    Browse the repository at this point in the history

  5. removed the actual dummy queries from the test, as they need to be di… 

    …fferent for different databases, and the tests seem to be just as valid wihtout them.
    @oranoran
    oranoran committed Oct 26, 2019
    Copy the full SHA
    b0c2c39 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2019

  1. added comment explaining delete

    @oranoran
    oranoran committed Oct 27, 2019
    Copy the full SHA
    6737033 View commit details
    Browse the repository at this point in the history

  2. Added typescript definition for optional Boolean expirationChecker fu… 

    …nction in connection objects.
    @oranoran
    oranoran committed Oct 27, 2019
    Copy the full SHA
    16de28f View commit details
    Browse the repository at this point in the history

  3. Added typescript definitions for connection config provider

    @oranoran
    oranoran committed Oct 27, 2019
    Copy the full SHA
    5b5b49e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/knex/knex into generic-co… 

    …nn-config-provider
    @oranoran
    oranoran committed Oct 27, 2019
    Copy the full SHA
    a005dc3 View commit details
    Browse the repository at this point in the history

  5. Fixed latest merge to not allow string as connection config returned … 

    …by provider. This is currently not supported since parsing a config string is done in knex.js while the connection config provider is implemented in client.js
    @oranoran
    oranoran committed Oct 27, 2019
    Copy the full SHA
    6398440 View commit details
    Browse the repository at this point in the history