New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use util.promisify instead of Bluebird.promisify #3470
Conversation
Not sure what to do with Bluebird.promisifyAll in https://github.com/tgriesser/knex/blob/master/lib/dialects/oracle/index.js#L85 |
node-oracle hasn't been updated since 2016 and is deprecated in favor of node-oracledb. Support for it can perhaps just be dropped. |
lib/migrate/MigrationGenerator.js
Outdated
return bluebird | ||
.promisify(fs.stat, { context: fs })(dir) | ||
.catch(() => bluebird.promisify(mkdirp)(dir)); | ||
return promisify(fs.stat)(dir).catch(() => promisify(mkdirp)(dir)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ context: fs }
part is irrelevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but i cant find it in official docs or changelogs
only this example
https://nodejs.org/docs/latest-v8.x/api/util.html#util_util_promisify_original
Bunch of conflicts came up. |
589025e
to
59bf421
Compare
Thanks! |
fixes #3257