add node-postgres keepAlive option #3293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taybin |
|
@kibertoad I'll do that. |
|
Don't merge this yet. After reading more of the node-postgres source, there's more config stuff I want to add, but need to see what the superset is with knex's config options as well. |
|
@taybin Please ping me when it'll be ready for merging! |
|
@taybin Any updates? |
|
@taybin Could you resolve conflicts? |
|
Superseded by #3372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-postgres now supports the keepAlive option, so let's allow it here as well.