New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test that clearing offset #2954

Merged

kibertoad merged 2 commits into knex:master from HurSungYun:add_test_clear_offset

Mar 5, 2019

Contributor

HurSungYun commented Dec 13, 2018

According to #2908,

clearing offset is valid case for Knex.js, but there's no test for it.

HurSungYun added 2 commits

December 13, 2018 20:17


          add test that clearing offset


          fix typo

cbc1b84

kibertoad approved these changes

View reviewed changes

kibertoad merged commit 0db7859 into knex:master

Collaborator

kibertoad commented Mar 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment