Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation in .offset() #2908

Merged
merged 14 commits into from Oct 15, 2019
+168 −1
Merged

add validation in .offset() #2908

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1a957da
add validation in `.offset()`
HurSungYun Nov 15, 2018
3ea7637
fix typo
HurSungYun Nov 15, 2018
9d04306
add test of limit warning message
HurSungYun Nov 16, 2018
9476420
skip sqlite
HurSungYun Nov 16, 2018
b593d40
add test for checking offset warning message
HurSungYun Nov 16, 2018
61b7a68
fix mssql query
HurSungYun Nov 16, 2018
d7e17ec
add unreachable point in test
HurSungYun Nov 16, 2018
9de3e14
Revert "add unreachable point in test"
HurSungYun Nov 16, 2018
b04282e
add nil check for backward-compatible
HurSungYun Dec 13, 2018
c94877f
merge master
Oct 8, 2019
d941cc3
offset works with Raw
Oct 8, 2019
5e74c3a
add tests for code coverage
HurSungYun Oct 8, 2019
4a8bcb9
var to const, uncomment sqlite
HurSungYun Oct 15, 2019
cdde64e
add useNullAsDefault to avoid error
HurSungYun Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/query/builder.js
View file
Open in desktop
Expand Up @@ -825,7 +825,12 @@ assign(Builder.prototype, {

// Only allow a single "offset" to be set for the current query.
offset(value) {
this._single.offset = value;
const val = parseInt(value, 10);
if (isNaN(val)) {
this.client.logger.warn('A valid integer must be provided to offset');
} else {
this._single.offset = val;
}
return this;
},

Expand Down