Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for TS 4.8 #5279

Merged
merged 1 commit into from Jul 30, 2022
Merged

Update types for TS 4.8 #5279

merged 1 commit into from Jul 30, 2022
+1 −1

Conversation

sandersn
Copy link
Contributor

@sandersn sandersn commented Jul 25, 2022 •
edited

Typescript 4.8 assumes that unconstrained types extend unknown, not {} (which is unknown minus null and undefined). However, many uses still need to extend {}. This PR does that explicitly for knex types.

See https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#unconstrained-generics-no-longer-assignable-to

@sandersn
Update types for TS 4.8
74f5447 
Typescript 4.8 assumes that unconstrained types extend `unknown`, not `{}` (which is `unknown` minus `null` and `undefined`). However, many uses still need to extend `{}`. This PR does that explicitly for knex types.
@sandersn sandersn mentioned this pull request Jul 27, 2022
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.272% when pulling 74f5447 on sandersn:update-types-ts-4.8 into 72065c1 on knex:master.

@kibertoad kibertoad merged commit 658cde3 into knex:master Jul 30, 2022
@kibertoad
Copy link
Collaborator

Thanks!

@sandersn sandersn deleted the update-types-ts-4.8 branch August 1, 2022 16:45
@kibertoad kibertoad mentioned this pull request Aug 26, 2022
Closed
@lizthegrey lizthegrey mentioned this pull request Aug 27, 2022
Closed
@jamesone
Copy link

I can't see that this fix was released. Knex 2.2.0 was released on 19th Jul, whereas this PR was merged on the 31th of July. @kibertoad How do knex releases work?

Jkovarik added a commit to nasa/cumulus that referenced this pull request Aug 31, 2022
@Jkovarik
Tightly constrain typescript verseion due to knex typing
f6fdfd7 
Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279
@Jkovarik Jkovarik mentioned this pull request Aug 31, 2022
Merged
4 tasks
@kibertoad
Copy link
Collaborator

Released in 2.3.0

Jkovarik added a commit to nasa/cumulus that referenced this pull request Aug 31, 2022
@Jkovarik
CUMULUS-3027 -- Tightly constrain typescript version due to knex typi…
e7d21c9 
…ng (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG
npauzenga pushed a commit to nasa/cumulus that referenced this pull request Oct 5, 2022
@Jkovarik @npauzenga
CUMULUS-3027 -- Tightly constrain typescript version due to knex typi…
9b5fb96 
…ng (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG
charleshuang80 pushed a commit to nasa/cumulus that referenced this pull request Oct 6, 2022
@Jkovarik @charleshuang80
CUMULUS-3027 -- Tightly constrain typescript version due to knex typi…
c56d1cd 
…ng (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG
charleshuang80 added a commit to nasa/cumulus that referenced this pull request Oct 10, 2022
@npauzenga @charleshuang80
@jennyhliu @Jkovarik
Release 12.0.3 (#3107)
13f055a 
* merge CUMULUS-2557

* merge CUMULUS-2971

* merge CUMULUS-3021

* merge CUMULUS-3024

* 12.0.3 version bump

* remove duplicate api user

* Sort results in unit test before comparison

* add ci stack

* CUMULUS-3027 -- Tightly constrain typescript version due to knex typing (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG

* Update CNM lambdas to utilize newer releases (#3094)

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>
Co-authored-by: Charles Huang <charles.huang@nasa.gov>
jennyhliu added a commit to nasa/cumulus that referenced this pull request Oct 18, 2022
@npauzenga @charleshuang80
@jennyhliu @Jkovarik
Release 13.3.x with master (#3121)
65204e3 
* Release 13.3.1 (#3106)

* merge CUMULUS-2557

* merge CUMULUS-2971

* CUMULUS-3021: Support Collections with a collection.version containing slashes (#3096)

* Support Collections with a collection.version containing slashes

* merge CUMULUS-3021

* merge CUMULUS-3024

* bump version to 13.3.1

* update documentation

* update changelog

* remove duplicate api user

* Sort results in unit test before comparison

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>

* CUMULUS-3027 -- Tightly constrain typescript version due to knex typing (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG

* Release 13.3.2 (#3117)

* Update CNM lambdas to utilize newer releases (#3094)

* 13.3.2 version bump

* update changelog

Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>

* update changelog

* re-add comma

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>
npauzenga added a commit to nasa/cumulus that referenced this pull request Oct 27, 2022
@npauzenga @charleshuang80
@jennyhliu @Jkovarik @botanical
[CUMULUS-3056] Setup for testing Postgres LIST queries (#3127)
2cf0559 
* initial commit

* add postgres query to LIST endpoints

* add tests for granules and collections

* Release 13.3.x with master (#3121)

* Release 13.3.1 (#3106)

* merge CUMULUS-2557

* merge CUMULUS-2971

* CUMULUS-3021: Support Collections with a collection.version containing slashes (#3096)

* Support Collections with a collection.version containing slashes

* merge CUMULUS-3021

* merge CUMULUS-3024

* bump version to 13.3.1

* update documentation

* update changelog

* remove duplicate api user

* Sort results in unit test before comparison

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>

* CUMULUS-3027 -- Tightly constrain typescript version due to knex typing (#3095)

* Tightly constrain typescript verseion due to knex typing

Unpinned dependency resulted in typescript 4.8 being installed,
however knex (all versions) has an outstanding bug:
knex/knex#5279

* Add CHANGELOG 🔔

* Update generate-ts-build-cache to always 'npm install'

* Update CHANGELOG

* Release 13.3.2 (#3117)

* Update CNM lambdas to utilize newer releases (#3094)

* 13.3.2 version bump

* update changelog

Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>

* update changelog

* re-add comma

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>

* fix lint error

* CUMULUS-3104:Update async operation image Dockerfile (#3130)

* CUMULUS-3104:Update async operation image Dockerfile to use node:14.19.3-buster
Upgraded saml2-js 4.0.0, rewire to 6.0.0 to address security vulnerabilities

* add xmldom to audit allowlist

* update default async_operation_image

* update changelog skip-integration-tests

* CUMULUS-2944: granules/bulkDelete endpoint has PayloadTooLargeError for 4k granules (#3122)

* Update body parser configuration to increase limit

* Add unit test, update changelog

* Update unit test and fix lint

* Fix lint errors

* Fix lint error

* Relocate granulesList.js and update reference in unit test

* Update helper function to dynamically generate IDs and move to different file. Update unit test

* Fix lint errors

* Increase limit to match lambda limit

* CUMULUS-3102: Update broken link (#3125)

* Fix docs that has bad link

* Update url to reference markdown file directly

* CUMULUS-3104: Fixed TS compilation error caused by @aws-sdk/client-s3 upgrade (#3132)

* Fixed TS compilation error caused by @aws-sdk/client-s3 3.190->3.193 upgrade

* fix cumulus/package.json

* update lerna to fix security vulnerability

* fix lzards-api-client package

* temporarily skip deleteS3Objects test

* remove @Cumulus from root, skip test deleteObjects, add missing package

* fix ci post build failure

* put xmldom back to allow list

* add comments for skipped test

Co-authored-by: Charles Huang <charleshuang80@users.noreply.github.com>
Co-authored-by: jennyhliu <34660846+jennyhliu@users.noreply.github.com>
Co-authored-by: Jonathan Kovarik <kovarik@nsidc.org>
Co-authored-by: Jennifer Tran <12633533+botanical@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sandersn @coveralls @kibertoad @jamesone