Same boolean handling in better-sqlite3 as in sqlite3 (#4982)

Co-authored-by: Olivier Cavadenti <olivier.cavadenti@gmail.com>
knex · Jan 31, 2022 · f9f6a38 · f9f6a38
1 parent f50554b
commit f9f6a38
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/dialects/better-sqlite3/index.js b/lib/dialects/better-sqlite3/index.js
@@ -56,7 +56,7 @@ class Client_BetterSQLite3 extends Client_SQLite3 {
       }
 
       if (typeof binding === 'boolean') {
-        return String(binding);
+        return Number(binding);
       }
 
       return binding;

diff --git a/test/integration2/schema/misc.spec.js b/test/integration2/schema/misc.spec.js
@@ -1412,6 +1412,22 @@ describe('Schema (misc)', () => {
                 'create index "10_test_table_logins_index" on "10_test_table" ("logins")',
               ]);
             }));
+
+        it('test boolean type with sqlite3 and better sqlite3 #4955', async function () {
+          if (!isSQLite(knex)) {
+            this.skip();
+          }
+          await knex.schema
+            .dropTableIfExists('test')
+            .createTable('test', (table) => {
+              table.boolean('value').notNullable();
+            });
+
+          await knex('test').insert([{ value: true }, { value: false }]);
+          const data = await knex('test').select();
+          expect(data[0].value).to.eq(1);
+          expect(data[1].value).to.eq(0);
+        });
       });
 
       describe('table', () => {