Added promisable and better types (#5222)

knex · Jun 14, 2022 · f80ec1c · f80ec1c
1 parent 0918bf9
commit f80ec1c
Show file tree

Hide file tree

Showing 2 changed files with 816 additions and 414 deletions.
diff --git a/test-tsd/querybuilder.test-d.ts b/test-tsd/querybuilder.test-d.ts
@@ -11,17 +11,17 @@ const knexInstance = knex(clientConfig);
 declare module '../types' {
   namespace Knex {
     interface QueryBuilder {
-      customSelect<TRecord, TResult>(
+      customSelect<TRecord extends {}, TResult> (
         value: number
-      ): Knex.QueryBuilder<TRecord, TResult>;
+      ): Promise<Knex.QueryBuilder<TRecord, TResult>>;
     }
   }
 }
 
 knex.QueryBuilder.extend('customSelect', function (value: number) {
-  return this.select(this.client.raw(`${value} as value`));
+  return new Promise((r) => r(this.select(this.client.raw(`${value} as value`))));
 });
 
 const main = async () => {
-  expectType<number[]>(await knexInstance('users').customSelect<any, number[]>(42));
+  expectType<number[]>(await (await knexInstance('users').customSelect<any, number[]>(42)));
 };