"esm module interop flag" reflects knex #3571 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Jan 14, 2020
sections/transactions.js
Outdated
| @@ -80,6 +80,75 @@ export default [ | |||
| }); | |||
| ` | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Was this part supposed to be included in this PR?..
There was a problem hiding this comment.
No, don't know who it got there :(
I tried to amend my initial commit , maybe its bringing master's merge history back to present like it is my own .
I didn't write that
Sorry,
reset to gh-pages re-apply changes
|
Did reset the branch to gh-pages |
kibertoad
approved these changes
Jan 15, 2020
|
Thanks, looks good! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows knex/knex#3616
Assuming build step is after knex#merge