Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not append the port to authority #12350

Merged
merged 3 commits into from Nov 25, 2021
Merged

Do not append the port to authority #12350

merged 3 commits into from Nov 25, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 25, 2021 •
edited

This patch stops to append the port to authority header for gRPC test.

grpc-go recently added the validation for aurhority and server name by grpc/grpc-go#4817
and the host with port in authority gets the following matching error:

    grpc_test.go:450: error:  ping gRPC error: ClientConn's authority from transport creds "grpc-load-balancing-dhlqibxf.serving-tests.example.com" and dial option "grpc-load-balancing-dhlqibxf.serving-tests.example.com:443" don't match

This patch fixes it.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 25, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021 •
edited

Codecov Report

Merging #12350 (2d3f2ed) into main (abf4d69) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12350      +/-   ##
==========================================
+ Coverage   87.46%   87.48%   +0.02%     
==========================================
  Files         195      195              
  Lines        9644     9644              
==========================================
+ Hits         8435     8437       +2     
+ Misses        929      926       -3     
- Partials      280      281       +1
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️
pkg/activator/net/revision_backends.go 92.60% <0.00%> (+0.86%) ⬆️
pkg/autoscaler/statserver/server.go 79.61% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf4d69...2d3f2ed. Read the comment docs.

@nak3
Copy link
Contributor Author

nak3 commented Nov 25, 2021

/test pull-knative-serving-https

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2021
@nak3
Copy link
Contributor Author

nak3 commented Nov 25, 2021

/test pull-knative-serving-https

@nak3
Copy link
Contributor Author

nak3 commented Nov 25, 2021

/test pull-knative-serving-https

@nak3 nak3 changed the title WIP: Do not append the port to authority Do not append the port to authority Nov 25, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2021
@nak3
Copy link
Contributor Author

nak3 commented Nov 25, 2021

/cc @markusthoemmes

markusthoemmes
markusthoemmes approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 95f1681 into knative:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Assignees

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nak3 @knative-prow-robot @markusthoemmes