Add lint for aliasing autoscaling import correctly

[julz]

Someone very kindly did the work to add the linter I hacked up for funsies when I fixed these before to golanglint-ci, so we might as well use it!

Also, fix up a package that I apparently forgot to git add when I fixed these before, and never spotted because we didn't lint it :).

/hold I think I'll need to bump the golanglint-ci version in knative/.github before this will work

/assign @markusthoemmes

[codecov]

Codecov Report

Merging #10885 (1561a25) into main (05f16c6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #10885      +/-   ##
==========================================
- Coverage   87.99%   87.95%   -0.05%     
==========================================
  Files         188      188              
  Lines        9113     9113              
==========================================
- Hits         8019     8015       -4     
- Misses        839      842       +3     
- Partials      255      256       +1     

Impacted Files	Coverage Δ
pkg/apis/serving/v1/revision_lifecycle.go	92.72% <100.00%> (ø)
pkg/reconciler/revision/reconcile_resources.go	80.95% <0.00%> (-2.39%)	⬇️
pkg/activator/net/revision_backends.go	90.41% <0.00%> (-0.92%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f16c6...1561a25. Read the comment docs.

[markusthoemmes]

Pretty cool!

[vagababov]

But I liked the short one?
Why make it longer everywhere, rather than the other way?

[julz]

I don't actually care much (at all ;)) which alias we pick, so much as that we're consistent (it's easy to change the lint if we want a different import). I picked this alias in #10666 because it concatenates the final two bits of the path without the slash, which has at least some logic to it (and is consistent with how we generally import other things that clash, e.g. servingv1 etc).

[vagababov]

autoscaling is loooong :) so let's pick the short one.
It is also internal construct, so less important to be super explicit. :)

[julz]

If we do want to rename again, importas has a handy -fix mode that can do it automatically 😈, but I don't personally feel like I care enough (and there's at least some rationale for the concatenation)

[julz]

rebased, hopefully this should run nicely now golangci-lint version is bumped 🤞

[markusthoemmes]

This needs another rebase now and some workaround for the misspell issue :(

[julz]

lets try this again

[julz]

\o/ think everything has now trickled through and this is mergable!

/unhold

[markusthoemmes]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment