Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Bump sarama from v1.26.4 to v1.27.0 #1510

Merged
merged 1 commit into from Aug 31, 2020
Merged

Bump sarama from v1.26.4 to v1.27.0 #1510

merged 1 commit into from Aug 31, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 27, 2020 •
edited

Proposed Changes

Release Note

- 馃巵 Add new feature
Kafka Channel and Kafka Source support Kafka 2.6

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 27, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 27, 2020
@pierDipi
Copy link
Member Author

Flaky #1433
/retest

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

Flaky #1424

    operation.go:94: Failed to get all KResources ready failed waiting for {TypeMeta:{Kind:Trigger APIVersion:eventing.knative.dev/v1} ObjectMeta:{Name:trigger GenerateName: Namespace:test-broker-redelivery-kafka-channel-messaging-knative-devn482p SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
    operation.go:115: Failed to get all test resources ready: failed waiting for {TypeMeta:{Kind:Trigger APIVersion:eventing.knative.dev/v1} ObjectMeta:{Name:trigger GenerateName: Namespace:test-broker-redelivery-kafka-channel-messaging-knative-devn482p SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
        knative.dev/eventing/test/lib.(*Client).WaitForAllTestResourcesReadyOrFail
        	/home/prow/go/src/knative.dev/eventing-contrib/vendor/knative.dev/eventing/test/lib/operation.go:115
        knative.dev/eventing/test/e2e/helpers.brokerRedelivery
        	/home/prow/go/src/knative.dev/eventing-contrib/vendor/knative.dev/eventing/test/e2e/helpers/broker_redelivery_helper.go:103
        knative.dev/eventing/test/e2e/helpers.BrokerRedelivery.func1
        	/home/prow/go/src/knative.dev/eventing-contrib/vendor/knative.dev/eventing/test/e2e/helpers/broker_redelivery_helper.go:42
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

{
          "apiVersion": "eventing.knative.dev/v1",
          "kind": "Trigger",
          "metadata": {
            "annotations": {
              "eventing.knative.dev/creator": "prow-job@knative-tests.iam.gserviceaccount.com",
              "eventing.knative.dev/lastModifier": "prow-job@knative-tests.iam.gserviceaccount.com"
            },
            "creationTimestamp": "2020-08-27T18:41:07Z",
            "generation": 1,
            "labels": {
              "eventing.knative.dev/broker": "kafkachannel"
            },
            "name": "trigger",
            "namespace": "test-broker-redelivery-kafka-channel-messaging-knative-devn482p",
            "resourceVersion": "27965",
            "selfLink": "/apis/eventing.knative.dev/v1/namespaces/test-broker-redelivery-kafka-channel-messaging-knative-devn482p/triggers/trigger",
            "uid": "a5be8e6a-dc4b-4d13-b38d-9305c9e0937d"
          },
          "spec": {
            "broker": "kafkachannel",
            "filter": {},
            "subscriber": {
              "ref": {
                "apiVersion": "v1",
                "kind": "Service",
                "name": "event-record"
              }
            }
          },
          "status": {
            "conditions": [
              {
                "lastTransitionTime": "2020-08-27T18:41:07Z",
                "message": "Channel does not have an address.",
                "reason": "NoAddress",
                "status": "False",
                "type": "BrokerReady"
              },
              {
                "lastTransitionTime": "2020-08-27T18:41:07Z",
                "status": "Unknown",
                "type": "DependencyReady"
              },
              {
                "lastTransitionTime": "2020-08-27T18:41:07Z",
                "message": "Channel does not have an address.",
                "reason": "NoAddress",
                "status": "False",
                "type": "Ready"
              },
              {
                "lastTransitionTime": "2020-08-27T18:41:07Z",
                "status": "Unknown",
                "type": "SubscriberResolved"
              },
              {
                "lastTransitionTime": "2020-08-27T18:41:07Z",
                "status": "Unknown",
                "type": "SubscriptionReady"
              }
            ],
            "observedGeneration": 1
          }
        }

/retest

@pierDipi
Copy link
Member Author

/retest

matzew
matzew reviewed Aug 28, 2020
View reviewed changes
kafka/common/pkg/kafka/consumer_handler_test.go
@@ -42,6 +42,10 @@ type mockConsumerGroupSession struct {
marked bool
}

func (m *mockConsumerGroupSession) Commit() {
panic("implement me")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi was that introduced on 1.27.x APIs ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they added the ability to manually committing offsets. Commit performs a blocking synchronous operation.

matzew
matzew approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 28, 2020
@pierDipi
Bump sarama from v1.26.4 to v1.27.0
bb8b758 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Aug 28, 2020
@pierDipi
Copy link
Member Author

Rebased.

@pierDipi pierDipi requested a review from matzew August 28, 2020 15:11
@pierDipi
Copy link
Member Author

Flaky #1424
/retest

matzew
matzew approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

knative/eventing#3966 is in. 馃帀
/retest

@knative-prow-robot knative-prow-robot merged commit aeec26c into knative:master Aug 31, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Sep 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@lberk lberk Awaiting requested review from lberk

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierDipi @googlebot @knative-prow-robot @matzew