Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions working group teams to peribolos #1091

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Add functions working group teams to peribolos #1091

merged 3 commits into from
Jun 29, 2022

Conversation

lance
Copy link
Member

@lance lance commented Jun 7, 2022

Signed-off-by: Lance Ball lball@redhat.com

Seems to be required for: #1032

@lance
Add functions working group teams to peribolos
2f32d90 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from dprotaso June 7, 2022 16:42
@knative-prow
Copy link

knative-prow bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
dprotaso
dprotaso reviewed Jun 7, 2022
View reviewed changes
peribolos/knative.yaml Outdated
Comment on lines 817 to 820
teams:
Func WG Leads:
description: The Working Group Leads for Functions
privacy: closed
Copy link
Member

@dprotaso dprotaso Jun 7, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to drop this nested team and add it in a separate PR

it's really annoying

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's really annoying

Yes! Yes it is! 😭

lance added 2 commits June 7, 2022 15:31
@lance
fixup: remove nested team since peribolos is not smart
223f085 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
fixup: oops - run update-codegen.sh
92d88e5 
Signed-off-by: Lance Ball <lball@redhat.com>
@chaodaiG
Copy link
Contributor

chaodaiG commented Jun 8, 2022

/retest

@vaikas
Copy link
Contributor

vaikas commented Jun 9, 2022

/test pull-knative-peribolos
Just in case this was fixed by the #1095 as well :)

@krsna-m krsna-m mentioned this pull request Jun 15, 2022
Closed
@krsna-m
Copy link
Contributor

krsna-m commented Jun 24, 2022

pull-knative-peribolos should be optional (can be merged even if it fails) now, while we get some answers from people working on peribolos.

@lance
Copy link
Member Author

lance commented Jun 28, 2022

/override pull-knative-peribolos

@knative-prow
Copy link

knative-prow bot commented Jun 28, 2022

@lance: Overrode contexts on behalf of lance: pull-knative-peribolos

In response to this:

/override pull-knative-peribolos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor

krsna-m commented Jun 28, 2022

/lgtm
/hold in case of any other comments?

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@lance
Copy link
Member Author

lance commented Jun 29, 2022

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2022
@knative-prow knative-prow bot merged commit f17b4bf into knative:main Jun 29, 2022
krsna-m added a commit to krsna-m/community that referenced this pull request Jul 20, 2022
@krsna-m
Revert "Add functions working group teams to peribolos (knative#1091)"
20879c4 
This reverts commit f17b4bf.
knative-prow bot pushed a commit that referenced this pull request Jul 20, 2022
@krsna-m
Revert changes that broke peribolos (#1113)
d785eea 
* Revert "Add functions working group teams to peribolos (#1091)"

This reverts commit f17b4bf.

* Fix team name collision. Revert adding Productivity as Knative-admins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

Assignees

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lance @chaodaiG @vaikas @krsna-m @dprotaso