Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automated] Update actions #411

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[Automated] Update actions #411

merged 1 commit into from
Mar 9, 2021

Conversation

knative-automation
Copy link
Contributor

Produced via:

# meta: knative-sandbox/.github
# main: knative-sandbox/sample-controller
cp $(find "${GITHUB_WORKSPACE}/meta/workflow-templates" -type f -name '*.yaml') \
  "${GITHUB_WORKSPACE}/main/.github/workflows/"

Cron. -knative-prow-robot
/cc knative-sandbox/api-core-wg-leads
/assign knative-sandbox/api-core-wg-leads

@knative-automation
Update common github actions
9021c58 
Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation requested review from a team as code owners March 9, 2021 01:33
@knative-prow-robot knative-prow-robot requested a review from a team March 9, 2021 01:34
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited

Codecov Report

Merging #411 (9021c58) into main (022bf20) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   27.77%   27.77%           
=======================================
  Files           7        7           
  Lines          36       36           
=======================================
  Hits           10       10           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022bf20...9021c58. Read the comment docs.

@tcnghia
Copy link
Contributor

tcnghia commented Mar 9, 2021

/hold

See knative-extensions/.github#96 (comment)

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
n3wscott
n3wscott approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good job bot!

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2021
@n3wscott
Copy link
Contributor

n3wscott commented Mar 9, 2021

/close

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n3wscott
Copy link
Contributor

n3wscott commented Mar 9, 2021

/reopen

@knative-prow-robot
Copy link
Contributor

@n3wscott: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tcnghia
Copy link
Contributor

tcnghia commented Mar 9, 2021

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
tcnghia
tcnghia approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 01fe2ba into knative-extensions:main Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcnghia tcnghia tcnghia approved these changes

@n3wscott n3wscott n3wscott approved these changes

@fallback-notification-blocker fallback-notification-blocker Awaiting requested review from fallback-notification-blocker

Assignees

@tcnghia tcnghia

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knative-automation @tcnghia @n3wscott @knative-prow-robot