Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade linter for now since the release ain't available #100

Closed
wants to merge 1 commit into from
Closed

Downgrade linter for now since the release ain't available #100

wants to merge 1 commit into from

Conversation

markusthoemmes
Copy link
Contributor

As pointed out by @tcnghia and golangci/golangci-lint#1813.

/assign @julz

@markusthoemmes markusthoemmes requested review from a team as code owners March 9, 2021 12:45
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2021
julz
julz approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this also will be fixed when golangci/golangci-lint#1827 lands, which may end up being quicker than this will propagate but 🤷🏼, still safer to fix both ways

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julz
To complete the pull request process, please assign markusthoemmes after the PR has been reviewed.
You can assign the PR to them by writing /assign @markusthoemmes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@julz
Copy link
Contributor

julz commented Mar 9, 2021

/hold think this is fixed now golangci/golangci-lint#1827 merged!

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@markusthoemmes
Copy link
Contributor Author

Works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz julz approved these changes

@fallback-notification-blocker fallback-notification-blocker Awaiting requested review from fallback-notification-blocker

Assignees

@julz julz

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markusthoemmes @knative-prow-robot @julz