New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Unwatch function for file provider #245
Open
prateek-narsinghani
wants to merge
6
commits into
knadh:master
Choose a base branch
from
prateek-narsinghani:file-provider-unwatch-fn
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
adding Unwatch function for file provider #245
prateek-narsinghani
wants to merge
6
commits into
knadh:master
from
prateek-narsinghani:file-provider-unwatch-fn
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhnvrm
requested changes
Nov 7, 2023
@rhnvrm , I have made the following changes:
|
@prateek-narsinghani thanks for the PR. Could you please add tests for this as well? |
@knadh I have added a test for the Unwatch function. Let me know if any further changes are required. |
rhnvrm
reviewed
Dec 4, 2023
prateek-narsinghani
force-pushed
the
file-provider-unwatch-fn
branch
from
December 4, 2023 14:35
65ec25c
to
3b8a879
Compare
rhnvrm
requested changes
Mar 6, 2024
prateek-narsinghani
force-pushed
the
file-provider-unwatch-fn
branch
from
April 5, 2024 18:54
0bc0e3e
to
91c6bac
Compare
prateek-narsinghani
force-pushed
the
file-provider-unwatch-fn
branch
from
April 5, 2024 18:57
91c6bac
to
6dc3b80
Compare
rhnvrm
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.