Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional support net/http transport #232

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat: optional support net/http transport #232

merged 1 commit into from
Sep 15, 2023

Conversation

missedone
Copy link
Contributor

in our qa environment, we have misconfigured SSL setup for Vault, but it would take time to fix and may potentially block the development, so i'd like to introduce a new flag InsecureSkipVerify to allow the koanf valut ext to skip the SSL verification.

@knadh
Copy link
Owner

knadh commented Sep 13, 2023

If there are other TLS related fields that may be useful in the future, rather than adding InsecureSkipVerify to the config root, We could add TLS { InsecureSkipVerify ... }?

@knadh knadh added the enhancement New feature or request label Sep 13, 2023
@missedone
Copy link
Contributor Author

Good point, how about make transport or http client configurable?

@knadh
Copy link
Owner

knadh commented Sep 13, 2023

Yep. Can take an optional *http.Client in the config instead.

@missedone
Copy link
Contributor Author

@knadh , i thought it twice, most of time we just need to customize Transport, and updated the PR with optional Transport

@missedone missedone changed the title feat: support net/http transport InsecureSkipVerify feat: optional support net/http transport Sep 13, 2023
@missedone
Copy link
Contributor Author

@knadh could you review the pr once have time, i will start working on #233 afterwards

@knadh knadh merged commit 4e88645 into knadh:master Sep 15, 2023
3 checks passed
@missedone missedone deleted the feat/InsecureSkipVerify branch September 15, 2023 05:06
codeboten pushed a commit to open-telemetry/opentelemetry-collector that referenced this pull request Feb 6, 2024
@renovate @opentelemetrybot
Update module github.com/knadh/koanf/v2 to v2.0.2 (#9469)
5c2fc22 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/knadh/koanf/v2](https://togithub.com/knadh/koanf) |
`v2.0.1` -> `v2.0.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.1/v2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.1/v2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>knadh/koanf (github.com/knadh/koanf/v2)</summary>

### [`v2.0.2`](https://togithub.com/knadh/koanf/releases/tag/v2.0.2)

[Compare
Source](https://togithub.com/knadh/koanf/compare/v2.0.1...v2.0.2)

#### What's Changed

- feat: add nats provider by
[@&#8203;TECHNOFAB11](https://togithub.com/TECHNOFAB11) in
[knadh/koanf#213
- feat: add flag to optionally fetch secret metadata by
[@&#8203;Thunderbottom](https://togithub.com/Thunderbottom) in
[knadh/koanf#219
- chore: change WithMeta to ExcludeMeta for backwards compatibility by
[@&#8203;Thunderbottom](https://togithub.com/Thunderbottom) in
[knadh/koanf#220
- typos and little clearer code by
[@&#8203;GreyXor](https://togithub.com/GreyXor) in
[knadh/koanf#222
- Fixed a nil panic issue in vault provider by
[@&#8203;wangkang](https://togithub.com/wangkang) in
[knadh/koanf#224
- Not use deprecated io/ioutil by
[@&#8203;tchssk](https://togithub.com/tchssk) in
[knadh/koanf#226
- Proposal: support Vault auth method by
[@&#8203;missedone](https://togithub.com/missedone) in
[knadh/koanf#229
- Add parameterstore provider by
[@&#8203;tchssk](https://togithub.com/tchssk) in
[knadh/koanf#227
- feat: optional support net/http transport by
[@&#8203;missedone](https://togithub.com/missedone) in
[knadh/koanf#232
- breaking change:
[#&#8203;233](https://togithub.com/knadh/koanf/issues/233) return error
struct to avoid panic at runtime by
[@&#8203;missedone](https://togithub.com/missedone) in
[knadh/koanf#234
- Bump github.com/nats-io/nkeys from 0.4.4 to 0.4.6 in /providers/nats
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#246
- Bump golang.org/x/net from 0.7.0 to 0.17.0 in /providers/etcd by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#248
- Bump golang.org/x/net from 0.7.0 to 0.17.0 in /providers/vault by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#247
- Bump github.com/nats-io/nats-server/v2 from 2.9.15 to 2.9.23 in
/providers/nats by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[knadh/koanf#241
- Bump google.golang.org/grpc from 1.53.0 to 1.56.3 in /providers/etcd
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#243
- fix: typo by [@&#8203;testwill](https://togithub.com/testwill) in
[knadh/koanf#251
- Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /providers/vault by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#261
- Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /providers/nats by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[knadh/koanf#260
- Add optional `Opt{}` param that takes a koanf instance to match
posflag's default value behaviour in basic flag. Closes
[#&#8203;255](https://togithub.com/knadh/koanf/issues/255). by
[@&#8203;knadh](https://togithub.com/knadh) in
[knadh/koanf#259
- Parser: KDL by [@&#8203;dezren39](https://togithub.com/dezren39) in
[knadh/koanf#266
- Parser: KDL kdl-go dependency update by
[@&#8203;dezren39](https://togithub.com/dezren39) in
[knadh/koanf#267

#### New Contributors

- [@&#8203;TECHNOFAB11](https://togithub.com/TECHNOFAB11) made their
first contribution in
[knadh/koanf#213
- [@&#8203;GreyXor](https://togithub.com/GreyXor) made their first
contribution in
[knadh/koanf#222
- [@&#8203;wangkang](https://togithub.com/wangkang) made their first
contribution in
[knadh/koanf#224
- [@&#8203;tchssk](https://togithub.com/tchssk) made their first
contribution in
[knadh/koanf#226
- [@&#8203;missedone](https://togithub.com/missedone) made their first
contribution in
[knadh/koanf#229
- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[knadh/koanf#251
- [@&#8203;dezren39](https://togithub.com/dezren39) made their first
contribution in
[knadh/koanf#266

**Full Changelog**:
knadh/koanf@v2.0.1...v2.0.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@missedone @knadh