Tests added for Read() in env #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Different test cases added. Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
|
Hi @gozeloglu , if you're planning on adding more tests for the same package, please amend this PR to include all of them. It wouldn't be ideal to merge PRs per function in the same small package. Thanks! |
|
Hi @knadh. OK, you are right. I'll consider adding more tests for the |
* Added more test and existing code refactored. Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
|
Hi @knadh. I refactored the |
|
Hi @knadh. This is a kindly ping. Could you please review my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests for
Read()in env.go. I can add more test cases if you want.Signed-off-by: Gökhan Özeloğlu gozeloglu@gmail.com