Add tests for env.go #132
Merged
Add tests for env.go #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Nil cb and empty string prefix cases handled. Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I wanted to add tests for
env.go. I added two test cases and also tried to add for non-nil cb cases but I was not succeeded to add them. I know this does not cover all cases, but this first commit can be seen as the first starting point of theenv_test.go. I am ready to add other test cases with your help. I can refactor the code if you want as well.Signed-off-by: Gökhan Özeloğlu gozeloglu@gmail.com