Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator refresh interval #2154

Merged
merged 8 commits into from May 13, 2024
Merged

Update validator refresh interval #2154

merged 8 commits into from May 13, 2024

Conversation

hyeonLewis
Copy link
Contributor

@hyeonLewis hyeonLewis commented May 9, 2024

Proposed changes

This PR updates the validator refresh interval to 1 block, which is currently approx. 1 day (= 86,400 blocks). The validator set at block N now will be determined by staking info at block N-1 if N is Kaia fork block.

Since the Kaia fork, the multicall contract will also be activated. Please check #2158 to know what multicall is and how it works with this.

The snap sync mode will be temporary disabled due to issue related to staking info sync.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyeonLewis hyeonLewis self-assigned this May 9, 2024
@hyeonLewis hyeonLewis marked this pull request as draft May 9, 2024 10:36
@hyeonLewis hyeonLewis marked this pull request as ready for review May 10, 2024 07:00
@hyeonLewis hyeonLewis force-pushed the stakinginfo-interval branch 5 times, most recently from 803c7cb to b87d5df Compare May 11, 2024 13:41
@hyeonLewis hyeonLewis mentioned this pull request May 12, 2024
9 tasks
@blukat29 blukat29 merged commit ff67bcf into dev May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants