Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KAIABridge] Added KAIABridge contracts #2151

Closed
wants to merge 7 commits into from

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

KAIABridge contracts and unit tests were added

@ian0371, @hyeonLewis Could you please review this implementation?

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@hyeonLewis hyeonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyunsooda Do you manually bring XXXUpgradable since adding contracts-upgradeable@5.0 package is broken due to missing peer dependency? They're currently importing lower version, which is strongly discouraged. I think we need to import contracts-upgradeable@5.0 if we want to keep maintaining all contracts in klayn (kaia).

@blukat29
Copy link
Contributor

Hello, could you either (1) rebase against the latest dev or (2) git fetch --all && git cherry-pick 946bfe6? This will fix the CI failure.

@hyunsooda
Copy link
Contributor Author

@ian0371, @hyeonLewis Updated based on your valuable comments. Please close if each issue is correctly patched

Copy link
Contributor

@ian0371 ian0371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

@blukat29
Copy link
Contributor

@hyunsooda Do not merge the dev. Please rebase against the latest dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants