New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KAIABridge] Added KAIABridge contracts #2151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyunsooda Do you manually bring XXXUpgradable
since adding contracts-upgradeable@5.0
package is broken due to missing peer dependency? They're currently importing lower version, which is strongly discouraged. I think we need to import contracts-upgradeable@5.0
if we want to keep maintaining all contracts in klayn (kaia).
contracts/contracts/system_contracts/kaiabridge/EnumerableSetUpgradable.sol
Outdated
Show resolved
Hide resolved
Hello, could you either (1) rebase against the latest dev or (2) |
@ian0371, @hyeonLewis Updated based on your valuable comments. Please close if each issue is correctly patched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase
@hyunsooda Do not merge the dev. Please rebase against the latest dev. |
Co-authored-by: Chihyun Song <ian0371@gmail.com>
contract. 3. Disable the `transfer` function by default
Proposed changes
KAIABridge contracts and unit tests were added
@ian0371, @hyeonLewis Could you please review this implementation?
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...