Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only push failed tasks to queue #2149

Merged
merged 2 commits into from May 10, 2024
Merged

Only push failed tasks to queue #2149

merged 2 commits into from May 10, 2024

Conversation

hyeonLewis
Copy link
Contributor

Proposed changes

In queue, taskQueue contains tasks that need to be reserved to fetch data from peer. In deliver, it delivers the retrieval data packet from peers to fetchResult

However, currently, deliver pushes all requested headers back to taskQueue, which generates redundant staled tasks. This PR fixes to push only invalidated request to queue.

Reference: https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/queue.go#L940

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

blukat29
blukat29 previously approved these changes May 8, 2024
@blukat29
Copy link
Contributor

Could you retry after this?

git fetch
git cherry-pick 946bfe6

@blukat29 blukat29 merged commit 1d08c9c into dev May 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants