New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add klay_getTotalSupply API #2148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
force-pushed
the
supply-api
branch
4 times, most recently
from
May 8, 2024 07:22
51233ef
to
5c7cb0a
Compare
blukat29
force-pushed
the
supply-api
branch
20 times, most recently
from
May 13, 2024 01:48
fd37bed
to
a1bfd7f
Compare
blukat29
changed the title
Add klay_getTotalSupply and klay_getCirculatingSupply API
Add klay_getTotalSupply and klay_getTotalBurnt API
May 13, 2024
blukat29
force-pushed
the
supply-api
branch
3 times, most recently
from
May 13, 2024 09:57
5c5acc4
to
2a95547
Compare
ian0371
reviewed
May 14, 2024
ian0371
reviewed
May 14, 2024
ian0371
previously approved these changes
May 15, 2024
hyeonLewis
previously approved these changes
May 15, 2024
Co-authored-by: Lewis <lewis.kim@klaytn.foundation>
Co-authored-by: Chihyun Song <ian0371@gmail.com>
ian0371
approved these changes
May 16, 2024
jeongkyun-oh
approved these changes
May 16, 2024
hyeonLewis
approved these changes
May 16, 2024
2dvorak
approved these changes
May 16, 2024
This was referenced May 17, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
reward.GetTotalReward(num) -> <Minted, BurntFee>
which is a lightweight version ofreward.GetBlockReward
that only returns the total minted and burnt amounts, oblivious of validator staking amounts.AccRewards
whereklay_getTotalSupply(num)
Cypress example
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments