Add PebbleDB (WIP)

[junha-ahn]

Proposed changes

• Add PebbleDB

Types of changes

• Bugfix
• New feature or enhancement
• Others

Checklist

• I have read the CONTRIBUTING GUIDELINES doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes ($ make test)
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

Related issues

...

Further comments

[CLAassistant]

All committers have signed the CLA.

[blukat29]

Please include the pebbleDB to db_manager_test so that we can continuously test while you push commits to this PR branch.

[junha-ahn]

I added PebbleDB unit test into db_manager_test.go. and the tests I changed run successfully on my local machine. However, Im not sure why the CI jobs failed. (with below log) Do I need to do something?

Error response from daemon: pull access denied for wurstmeister/zookeeper, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

I will also add metrics features soon, and apply lint

and If there are any tests that we need to add, plz let me know, I will try to implement them.

[hyeonLewis]

I added PebbleDB unit test into db_manager_test.go. and the tests I changed run successfully on my local machine. However, Im not sure why the CI jobs failed. (with below log) Do I need to do something?

Error response from daemon: pull access denied for wurstmeister/zookeeper, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

There's an issue related to zookeeper, and will be fixed soon (see #2147)

[junha-ahn]

I added metrics and all the logic from pebble.go in Geth

Do I need to make the metrics key the same as in the leveldb_database.go code?

- d.compWriteMeter = metrics.GetOrRegisterMeter(prefix+"compact/output", nil)
+ db.compWriteMeter = metrics.GetOrRegisterMeter(prefix+"compaction/write", nil) 

"compact/output" from Geth PebbleDB file
"compaction/write" from Klaytn levelDB file

[junha-ahn]

NOTE: I need to refer to the RocksDB PR

[hyeonLewis]

Did you intentionally remove all comments? If not, please bring comments together.

[junha-ahn]

Ok, I will bring all the comments.

[junha-ahn]

Metics

I asked about metics 4 days ago. Note it please

Lint

Ok, I followed by LIINT GUIDE executed below commands:

klaytn$ gofumpt -w .
klaytn$ goimports -w .

When I run make lint on my local machine, it prints a lot of lint-bug that I didn't touch. So I don't know how to pass lint-ci

$ make lint 

env GOPATH=/Users/junha/go GO111MODULE=on go run build/ci.go lint
>>> /Users/junha/go/bin/golangci-lint run --tests --disable-all --timeout=10m --presets=format --presets=performance ./...
metrics/librato/client.go:94:38: response body must be closed (bodyclose)
        if resp, err = http.DefaultClient.Do(req); err != nil {
                                            ^
metrics/librato/client.go:87:31: should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
        if req, err = http.NewRequest("POST", MetricsPostUrl, bytes.NewBuffer(js)); err != nil {
                                     ^
console/jsre/pretty.go:32: File is not `gci`-ed with --skip-generated -s standard,default (gci)

consensus/istanbul/validator.go:26: File is not `gci`-ed with --skip-generated -s standard,default (gci)
        "github.com/klaytn/klaytn/params"

...

Test Failed on my local machine

Run by vscode go-extentions

When I run cmd/utils/nodecmd/flags_test.go on my local machine, it fails every time. Do you know anything about it?