New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code and comments cleaning for Randao and BLS #2060
Open
aidan-kwon
wants to merge
11
commits into
klaytn:dev
Choose a base branch
from
aidan-kwon:231207-randaoParent
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
requested review from
yoomee1313,
sjnam,
ian0371,
hyeonLewis and
blukat29
as code owners
December 7, 2023 09:30
aidan-kwon
commented
Dec 7, 2023
aidan-kwon
commented
Dec 7, 2023
aidan-kwon
commented
Dec 7, 2023
aidan-kwon
commented
Dec 7, 2023
aidan-kwon
commented
Dec 7, 2023
aidan-kwon
force-pushed
the
231207-randaoParent
branch
from
December 7, 2023 10:17
d5e484f
to
b800f95
Compare
ian0371
reviewed
Dec 8, 2023
sjnam
changed the title
Code and comments cleaning for Rando and BLS
Code and comments cleaning for Randao and BLS
Dec 8, 2023
blukat29
reviewed
Dec 8, 2023
aidan-kwon
force-pushed
the
231207-randaoParent
branch
from
December 8, 2023 03:31
b60082c
to
680495e
Compare
blukat29
previously approved these changes
Dec 8, 2023
aidan-kwon
requested review from
2dvorak,
kjeom and
JayChoi1736
as code owners
December 8, 2023 05:59
ian0371
approved these changes
Dec 8, 2023
hyeonLewis
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
headerMixHash
and add validation logic inCalcRandao
andVerifyRandao
headerMixHash
could returnnil
value and it can cause panic inVerfiyRandao
getAllCached
togetBlsInfos
if
conditions insnapshot.apply
valset.mixHash
only when it is not emptyweightedCouncil.Copy()
can make an empty slice for mixHash, and it make hard to checkingnil
value for mixHashTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)