Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and comments cleaning for Randao and BLS #2060

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

aidan-kwon
Copy link
Member

@aidan-kwon aidan-kwon commented Dec 7, 2023

Proposed changes

  • Remove headerMixHash and add validation logic in CalcRandao and VerifyRandao
    • headerMixHash could return nil value and it can cause panic in VerfiyRandao
  • Rename getAllCached to getBlsInfos
  • Remove unnecessary if conditions in snapshot.apply
  • Copy and assign valset.mixHash only when it is not empty
    • Since weightedCouncil.Copy() can make an empty slice for mixHash, and it make hard to checking nil value for mixHash
  • Add more comments

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

params/config.go Outdated Show resolved Hide resolved
consensus/istanbul/backend/snapshot.go Show resolved Hide resolved
@sjnam sjnam changed the title Code and comments cleaning for Rando and BLS Code and comments cleaning for Randao and BLS Dec 8, 2023
consensus/istanbul/backend/randao.go Outdated Show resolved Hide resolved
consensus/istanbul/backend/randao.go Outdated Show resolved Hide resolved
consensus/istanbul/backend/randao.go Outdated Show resolved Hide resolved
consensus/istanbul/backend/randao.go Outdated Show resolved Hide resolved
blukat29
blukat29 previously approved these changes Dec 8, 2023
@aidan-kwon aidan-kwon added the do not merge don't merge this PR yet label Dec 8, 2023
@blukat29 blukat29 removed the do not merge don't merge this PR yet label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants