vm: move interpreter.readOnly check and remove operation.writes field #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may miss relocating the guard to other storage modifications such as log , call, and selfdestruct. |
yoomee1313
force-pushed
the
vm/move-readonly-into-opcode-impl
branch
from
be6c8dd
to
9cf97e2
Compare
yoomee1313
requested review from
sjnam,
ian0371 and
hyeonLewis
as code owners
@hyunsooda I have checked that those opcodes already applied the change mentioned above. Could you check again? |
hyeonLewis
approved these changes
Nov 15, 2023
sjnam
approved these changes
Nov 15, 2023
|
Ah! I was in an outdated branch. Checked now. Thank you. |
hyunsooda
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR brings ethereum/go-ethereum#23970
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...