Simplify error handling in interpreter loop

[sjnam]

Proposed changes

ethereum/go-ethereum#23952

This simplifies interpreter loop exit condition to just err != nil. This catches:

• reverting instructions (i.e. just REVERT),
• halting instructions (by them returning errStopToken).

Also operation.jumps check is removed by setting pc - 1 inside the jump instruction and doing pc++ in the loop unconditionally.

Finally, instructions manipulating return data are handling this themselves. This eliminates another operation.returns check.

Types of changes

Please put an x in the boxes related to your change.

• Bugfix
• New feature or enhancement
• Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING GUIDELINES doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes ($ make test)
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

Related issues

• Implement EIP 6780 change in SELFDESTRUCT #1986

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...