Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABImetadata structure #1881

Merged
merged 5 commits into from Jul 18, 2023
Merged

Add ABImetadata structure #1881

merged 5 commits into from Jul 18, 2023

Conversation

JayChoi1736
Copy link
Contributor

Proposed changes

  • Add ABImetadata structure based on accounts/abi/bind: parse ABI once ethereum/go-ethereum#22583
  • get backward compatibility because {.Type}ABI, {.Type}FuncSigs, {.Type}Bin still exist in generated file, and logics about InputBinRuntime (which is for adding genesis block) does not changed
  • I think test is enough with the cases in bind_test.go

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

ethereum/go-ethereum#25574 will be added after this PR merge and convertType method added.

@blukat29
Copy link
Contributor

Please change func bind{{.Type}} to use {{.Type}}MetaData.GetAbi() (see https://github.com/ethereum/go-ethereum/blob/v1.11.5/accounts/abi/bind/template.go#L271), to be closer to geth.

Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @blukat29 mentioned, we need to cherry-pick https://github.com/ethereum/go-ethereum/pull/25574/files as well.

@JayChoi1736
Copy link
Contributor Author

@blukat29 @aidan-kwon resolved by c4fc5cd
remained part of ethereum/go-ethereum#25574 will be added with ethereum/go-ethereum#21091

@JayChoi1736 JayChoi1736 merged commit f7a08ce into klaytn:dev Jul 18, 2023
11 checks passed
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants