Add evm execution timeout #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeom
requested review from
KimKyungup,
aidan-kwon,
ehnuje,
henry-will,
hyunsooda,
nohkwak,
2dvorak,
jimni1222 and
JayChoi1736
as code owners
nohkwak
previously approved these changes
Dec 7, 2022
|
i've got on ken init.( the binary was builded on local m1 mac) |
Thanks, the flag should be removed at KENFlags in cmd/utils/nodecmd/nodeflags.go |
JayChoi1736
reviewed
Dec 8, 2022
JayChoi1736
approved these changes
Dec 8, 2022
nohkwak
approved these changes
Dec 8, 2022
henry-will
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
ADDITIONAL="--rpc.evmtimeout 10s"in kxxd.conf fileTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)